-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Emit invalidate events from client #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @sastcsgh, thanks for the PR, much appreciated! Im so sorry, we just merged a PR that touches on how you interact with the commands-queue. Those changes are in a bit of a conflict with your changes. It would be great if you fix the conflicts, then I can review more thoroughly. Just to give you some hints: |
No worries @nkaradzhov, the new pushHandler logic looks much more robust than the old solution anyway. |
@sastcsgh So sorry, i tried to fix the merge conflicts via the web interface, but actually made things worse... Can you please remove my last commit from your branch and fix the merge conflicts so we can run the tests again |
As far as I can tell, the only remaining issue was the changed |
@sastcsgh thank you, this looks good to go. Just want to have @bobymicroby give one final blessing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR adds an option to the client (
emitInvalidate
) that allows the client to emitinvalidate
events when it receives invalidation messages from the Redis server. This is similar to what the Client Side Cache does, except it doesn't require the cache to be enabled. This is useful when you want to perform certain transformations on the data from Redis and cache the result of these manually, while still being able to automatically receive invalidation events for the data you pull from the server.Checklist
npm test
pass with this change (including linting)?